URL path and query string gets lost after SSO redirect

wenpin.cui · October 10, 2024, 2:47pm

Hello, I ran into following issue:

A user accesses, for example: https://mycompany.com/data?id=1234
This user is not logged in pritunl-zero then gets redirected to the login page: https://mycompany.com/?redirect_url=%2Fdata%3Fid%3D1234

wenpin.cui · October 10, 2024, 2:48pm

Our pritunl-zero setup has OKTA as the only one authentication provider, and we have enabled fast_login as well as force_fast_service_login. We can see that user is redirected to the URL: https://mycompany.com/auth/request?id=<okta provider ID>. In this step the query string and URL path is lost.
After user is authenicated, user is redirected to URL: https://mycompany.com

wenpin.cui · October 10, 2024, 2:49pm

By disabling fast_login, the issue is gone.

However I do want to have fast_login enabled. Checked the code, I believe this can be fixed by passing the originl URL info to the function GetFastServicePath()

github.com

pritunl/pritunl-zero/blob/master/auth/state.go#L164-L171


      
          
          	for _, provider := range settings.Auth.Providers {
          		if provider.Type == Google {
          			path = fmt.Sprintf("/auth/request?id=%s", Google)
          		} else {
          			path = fmt.Sprintf("/auth/request?id=%s", provider.Id.Hex())
          		}
          		if redirectUrl != "" {

Sorry have to split the question into 3 parts as new user is disallowed to post more than 2 links.

zach · October 11, 2024, 7:46am

This has been fixed in the repository and will be included in the next release.

wenpin.cui · October 12, 2024, 8:26am

Do we have an ETA of next release?

zach · October 12, 2024, 11:40pm

This should be available later this week.

wenpin.cui · October 21, 2024, 2:48pm

@zach Thanks for fixing the issue.

The new version is available, do you have plan to update docker image?

zach · October 21, 2024, 3:25pm

The latest Docker Pritunl Zero image is now available.